diff options
| author |   Sam James <sam@gentoo.org> | 2024-05-22 02:40:06 +0100 |
|---|---|---|
| committer | Sam James <sam@gentoo.org> | 2024-05-22 02:43:56 +0100 |
| commit | 69d4cc312072ad28491d2dce5798dd49d63713e5 (patch) | |
| tree | 956858791e7bfafe605a45899932fad554d26022 /eclass/perl-module.eclass | |
| parent | media-tv/plex-media-server: drop 1.32.8.7639, 1.40.0.7998, 1.40.1.8227 (diff) | |
| download | gentoo-69d4cc312072ad28491d2dce5798dd49d63713e5.tar.gz gentoo-69d4cc312072ad28491d2dce5798dd49d63713e5.tar.bz2 gentoo-69d4cc312072ad28491d2dce5798dd49d63713e5.zip | |
perl-module.eclass: don't set 'ccflags' for Module::Build
TL;DR: If we set 'ccflags', we're clobbering the Perl default. We're already
setting 'optimize' which is what we're supposed to use here.
We set ccflags *and* optimize for Module::Build (which dev-perl/Net-DNS uses),
while we only set OPTIMIZE (case is fine) for MM (which dev-perl/Net-LibIDN2 uses).
ccflags clobbers the Perl default, while optimize appends. We should just set optimize -
to not clobber what Perl sets, but also for consistency between the two build systems).
(Unfortunately, this does mean we also inherit things we don't really
want to, which don't affect ABI, like -fno-strict-aliasing, but let's
live with it for now...)
Bug: https://bugs.gentoo.org/261375
Bug: https://bugs.gentoo.org/877659
Closes: https://bugs.gentoo.org/932176
Signed-off-by: Sam James <sam@gentoo.org>
Diffstat (limited to 'eclass/perl-module.eclass')
| -rw-r--r-- | eclass/perl-module.eclass | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass index f32c2c237d05..432d1ab315dd 100644 --- a/eclass/perl-module.eclass +++ b/eclass/perl-module.eclass @@ -279,7 +279,6 @@ perl-module_src_configure() { --config ld="$(tc-getCC)" \ --config nm="$(tc-getNM)" \ --config ranlib="$(tc-getRANLIB)" \ - --config ccflags="${CFLAGS}" \ --config optimize="${CFLAGS}" \ --config ldflags="${LDFLAGS}" \ "${myconf_local[@]}" |