summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAgeFilesLines
* metadata/install-qa-check.d: skip some checks when TMPFILES_OPTIONAL is setSam James2021-08-191-6/+6
| | | | | | | | | This is a good enough proxy for "this package has a complicated relationship with tmpfiles" and replaces the hardcoded list of exemptions. Closes: https://bugs.gentoo.org/808781 Signed-off-by: Sam James <sam@gentoo.org>
* metadata/install-qa-check.d: add check for missing tmpfiles_process callGeorgy Yakovlev2021-08-161-10/+24
| | | | | | See: https://archives.gentoo.org/gentoo-dev/message/7bdfdc9a7560fd07436defd0253af0b8 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org> Signed-off-by: Sam James <sam@gentoo.org>
* metadata/install-qa-check.d: add exemptions for some packages wrt inheritSam James2021-08-161-0/+8
| | | | | | | | | | | | Both sys-apps/systemd and sys-libs/pam need to install some files to these directories without inheriting the eclass. For future work, we should have a standardised way on opting out of installed files QA checks, but other QA checks are already suffering from this issue. See: https://archives.gentoo.org/gentoo-dev/message/0a96793036a4fdd9ac311a46950d7e7b Signed-off-by: Sam James <sam@gentoo.org>
* metadata/install-qa-check.d: only trigger on tmpfiles in forbidden locationSam James2021-08-161-1/+6
| | | | | | | It's okay to use "keepdir" on /etc/tmpfiles.d. See: https://archives.gentoo.org/gentoo-dev/message/50558b55dc34f37b238807fc4759640d Signed-off-by: Sam James <sam@gentoo.org>
* metadata/install-qa-check.d: add 60tmpfiles-path QA checkSam James2021-08-161-0/+37
| | | | | | | | | | | | | | This adds two tmpfiles related QA checks: 1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which is a forbidden (user-configuration) location; 2) Check whether packages inherit tmpfiles.eclass if they're installing files to /usr/lib/tmpfiles.d. (This helps to catch packages not calling tmpfiles_process in pkg_postinst). Signed-off-by: Sam James <sam@gentoo.org>
* metadata/layout.conf: Add profile-eapis-* keysUlrich Müller2021-08-131-0/+5
| | | | Signed-off-by: Ulrich Müller <ulm@gentoo.org>
* metadata/qa-policy.conf: Remove entry for l10nUlrich Müller2021-08-091-1/+0
| | | | Signed-off-by: Ulrich Müller <ulm@gentoo.org>
* install-qa-check.d: Switch DUS entry point check to pure bdependMichał Górny2021-08-021-12/+6
| | | | Signed-off-by: Michał Górny <mgorny@gentoo.org>
* darcs.eclass: remove last-rited eclassSam James2021-07-251-1/+0
| | | | Signed-off-by: Sam James <sam@gentoo.org>
* metadata/layout.conf: EAPI 6 is deprecatedUlrich Müller2021-07-111-1/+2
| | | | | | By 2021-07-11 council decision. Signed-off-by: Ulrich Müller <ulm@gentoo.org>
* l10n.eclass: Mark as deprecatedUlrich Müller2021-07-031-0/+1
| | | | Signed-off-by: Ulrich Müller <ulm@gentoo.org>
* metadata/install-qa-check.d: Skip DUS tests w/ DISTUTILS_OPTIONALMichał Górny2021-07-031-0/+9
| | | | | | | | | DISTUTILS_OPTIONAL skips setting the dependency on setuptools entirely, so skip checking for its correctness, and verbosely complain if it's set. Closs: https://bugs.gentoo.org/800147 Signed-off-by: Michał Górny <mgorny@gentoo.org>
* metadata/install-qa-check.d: adjust 60libcrypt-depsGeorgy Yakovlev2021-07-011-1/+1
| | | | | | check if ebuild has a dep on sys-libs/libxcrypt and return Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
* metadata/install-qa-check.d: add QA Notice string to all checksGeorgy Yakovlev2021-06-286-12/+15
| | | | | | | and re-wrap some lines to fit into 80 char limit Bug: https://bugs.gentoo.org/728046 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
* metadata/install-qa-check.d: add "QA Notice:" string to some checksGeorgy Yakovlev2021-06-282-4/+3
| | | | | Bug: https://bugs.gentoo.org/728046 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
* metadata/install-qa-check.d: add libcrypt tracker bugGeorgy Yakovlev2021-06-271-0/+1
| | | | Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
* metadata/install-qa-check.d: link wiki (developer guidance) in 60libcrypt-depsSam James2021-06-271-2/+3
| | | | Signed-off-by: Sam James <sam@gentoo.org>
* metadata/install-qa-check.d: fix some issues with 60libcrypt-depsGeorgy Yakovlev2021-06-261-4/+11
| | | | | Thanks-to: [Arfrever] Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
* metadata/install-qa-check.d: add virtual/libcrypt dep checkGeorgy Yakovlev2021-06-261-0/+38
| | | | | Bug: https://bugs.gentoo.org/699422 Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
* metadata/qa-policy.conf: Update list of deprecated eclassesUlrich Müller2021-06-231-6/+3
| | | | Signed-off-by: Ulrich Müller <ulm@gentoo.org>
* install-qa-check.d: Check for missing tests in distutils-r1 ebuildsMichał Górny2021-05-291-0/+32
| | | | Signed-off-by: Michał Górny <mgorny@gentoo.org>
* install-qa-check.d: expect unset DUS for bdependMichał Górny2021-05-251-1/+5
| | | | Signed-off-by: Michał Górny <mgorny@gentoo.org>
* layout.conf: Permit PROPERTIES=test_networkMichał Górny2021-05-191-2/+2
| | | | Signed-off-by: Michał Górny <mgorny@gentoo.org>
* install-qa-check.d: Make DUS aware of gui_scriptsMichał Górny2021-04-291-1/+1
| | | | | | | Make DISTUTILS_USE_SETUPTOOLS check aware of gui_scripts in addition to console_scripts. Thanks to Arfrever for reporting. Signed-off-by: Michał Górny <mgorny@gentoo.org>
* install-qa-check.d: Future-proof entry point values for DUSMichał Górny2021-04-291-6/+14
| | | | | | | | | | | | | | | Accept both 'rdepend' and 'bdepend' as DISTUTILS_USE_SETUPTOOLS values for packages installing entry points. Starting with Python 3.8, these packages do not require any runtime dependency. However, we do not want to proactively bother people with updating everything and instead provide the option to start performing opt-in updates. Note that technically PyPy3 (that implements Python 3.7 at the moment) continues requiring additional dependencies for entry point support. However, we do not support PyPy3 target in stable and generally do not consider it important enough to maintain extra complexity for. Signed-off-by: Michał Górny <mgorny@gentoo.org>
* install-qa-check.d: Extend DUS check to handle no egg-infoMichał Górny2021-04-291-1/+4
| | | | | | | | If the package does not install any .egg-info files, i.e. distutils is probably not used at all, we do not the eclass to create a setuptools dependency. Signed-off-by: Michał Górny <mgorny@gentoo.org>
* install-qa-check.d: Make DUS check distinguish entry pointsMichał Górny2021-04-291-8/+8
| | | | | | | | Make DISTUTILS_USE_SETUPTOOLS check explicitly distinguish rdepend due to entry points from explicit rdepend. This currently does not change the result but it will change in the future. Signed-off-by: Michał Górny <mgorny@gentoo.org>
* metadata/install-qa-check.d: disable non-applicable QA checks for EAPI 5Sam James2021-04-101-2/+2
| | | | | | Fixes: bdcfb21ca5a84567e9c9d6a456374a05e798f78e Closes: https://bugs.gentoo.org/781878 Signed-off-by: Sam James <sam@gentoo.org>
* metadata/layout.conf: ban EAPI 4(!)Sam James2020-11-261-2/+3
| | | | | | | | | | | Thanks to everyone for their help in eradicating these older ebuilds! (Including putting up with naggy bugs.) Bug: https://bugs.gentoo.org/756748 Closes: https://bugs.gentoo.org/656140 Signed-off-by: Sam James <sam@gentoo.org>
* install-qa-check.d/60distutils...: silence requires.txt errorMichał Górny2020-10-171-1/+2
| | | | Signed-off-by: Michał Górny <mgorny@gentoo.org>
* install-qa-check.d/60distutils...: Squash more false positivesMichał Górny2020-10-161-3/+3
| | | | | | Thanks to Arfrever for help with the pipeline. Signed-off-by: Michał Górny <mgorny@gentoo.org>
* metadata/qa-policy.conf: eutils.eclass is deprecated.Ulrich Müller2020-09-261-0/+1
| | | | Signed-off-by: Ulrich Müller <ulm@gentoo.org>
* install-qa-check.d: Fix DUS check for DISTUTILS_OPTIONALMichał Górny2020-09-221-30/+33
| | | | | | | | | | | Fix DISTUTILS_USE_SETUPTOOLS check to process all Python implementations with egg-infos present in site-packages (possibly none). This fixes eclass errors when trying to call distutils-r1 functions when it is actually disabled in DISTUTILS_OPTIONAL ebuilds. It also reduces noise while processing. Closes: https://bugs.gentoo.org/744079 Signed-off-by: Michał Górny <mgorny@gentoo.org>
* install-qa-check.d: Simply DISTUTILS_USE_SETUPTOOLS logicMichał Górny2020-09-221-25/+24
| | | | Signed-off-by: Michał Górny <mgorny@gentoo.org>
* install-qa-check.d: Allow bdepend/rdepend mix in DUS checkMichał Górny2020-09-221-2/+9
| | | | | | | | | Allow DISTUTILS_USE_SETUPTOOLS guess to partially evaluate to bdepend and partially to rdepend. That is the case in dev-python/hypothesis that installs CLI tools for CPython but not PyPy3. In this case, rdepend is the expected value. Signed-off-by: Michał Górny <mgorny@gentoo.org>
* install-qa-check.d: Fix reporting integrity-errors in DUS checkMichał Górny2020-09-221-4/+7
| | | | Signed-off-by: Michał Górny <mgorny@gentoo.org>
* install-qa-check.d: Account for setuptools in requires.txtMichał Górny2020-09-211-0/+4
| | | | Signed-off-by: Michał Górny <mgorny@gentoo.org>
* install-qa-check.d: add DISTUTILS_USE_SETUPTOOLS checkMichał Górny2020-09-211-0/+60
| | | | | | | | | | | | | | | | | | | | | Move DISTUTILS_USE_SETUPTOOLS check from distutils-r1.eclass to install QA checks, and rewrite it to use installed egg-info rather than greps on input files. This produces less false positives, particularly in packages that use boilerplate empty 'entry_points' in their setup script or configuration file. We also no longer require explicit setuptools RDEPEND for packages using other entry point types than console_scripts -- instead, we assume that the package consuming these entry points will bring setuptools as necessary. The rough idea is to look at egg-info metadata installed by distutils or setuptools. Plain distutils installs it as a regular file, while setuptools as a directory, and that's how we distinguish the two. For setuptools, we additionally grep entry_points.txt for `[console_scripts]`, and require RDEPEND when they are present. Signed-off-by: Michał Górny <mgorny@gentoo.org>
* python-utils-r1.eclass: Mark python_export privateMichał Górny2020-03-221-1/+1
| | | | Signed-off-by: Michał Górny <mgorny@gentoo.org>
* metadata/qa-policy.conf: Include deprecated eclassesMichał Górny2020-03-051-0/+16
| | | | Signed-off-by: Michał Górny <mgorny@gentoo.org>
* metadata/qa-policy.conf: Introduce QA check configurationMichał Górny2020-03-051-0/+63
| | | | | | | | | Introduce a new configuration file for assigning QA check significance levels to PGnnnn policies. Long-term goal is that this will permit unified configuration of various QA tools, including pkgcheck, repoman and install-qa-check.d. Signed-off-by: Michał Górny <mgorny@gentoo.org>
* metadata/install-qa-check.d/60appdata-path: new checkGeorgy Yakovlev2020-02-131-0/+35
| | | | | | | | | | this will warn if package installs xml files to /usr/share/appdata this location is deprecated, files should be installed to /usr/share/metainfo https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
* install-qa-check.d: disallow "nix" and "gnu" as top-level paths.Michael Orlitzky2020-01-201-2/+0
| | | | | | | These exceptions were made for the sys-apps/nix and sys-apps/guix packages that are no longer in the tree. Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
* metadata/install-qa-check.d/60python-pyc: Add EAPI guardMichał Górny2019-12-301-66/+69
| | | | | Closes: https://bugs.gentoo.org/704286 Signed-off-by: Michał Górny <mgorny@gentoo.org>
* metadata/layout.conf: Update comment for EAPI 0 ban.Ulrich Müller2019-12-091-2/+2
| | | | Signed-off-by: Ulrich Müller <ulm@gentoo.org>
* metadata/layout.conf: ban EAPI 0Aaron Bauman2019-12-091-2/+2
| | | | | | | Closes: https://bugs.gentoo.org/657150 Closes: https://bugs.gentoo.org/696252 Signed-off-by: Aaron Bauman <bman@gentoo.org>
* metadata/install-qa-check.d/08gentoo-paths: add guixSergei Trofimovich2019-11-121-1/+3
| | | | | | | | | | | sys-apps/nix and sys-apps/guix are twins: - sys-apps/nix manages /nix/store - sys-apps/guix manages /gnu/store Added 'gnu' and mentioned packages that own the directory. Bug: https://bugs.gentoo.org/670902 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
* install-qa-check.d/08gentoo-paths: add nix to allowed_paths_toplevelZac Medico2019-11-111-1/+1
| | | | | | Closes: https://bugs.gentoo.org/670902 Suggested-by: Michał Górny <mgorny@gentoo.org> Signed-off-by: Zac Medico <zmedico@gentoo.org>
* metadata/install-qa-check.d/08gentoo-paths: add explicit maintainerSergei Trofimovich2019-11-111-0/+3
| | | | | | | | | Bugs like bug #670902 get stuck due to unclear maintainership status. Let's assign it to dev-portage@ as it historicallily lived in portage source tree and QA does not take it over in bug #670902. Bug: https://bugs.gentoo.org/670902 Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
* metadata/layout.conf: Disallow RESTRICT=primaryuriMichał Górny2019-11-021-2/+2
| | | | | Bug: https://bugs.gentoo.org/696832 Signed-off-by: Michał Górny <mgorny@gentoo.org>