| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
|
|
|
|
|
| |
This is a good enough proxy for "this package has a complicated
relationship with tmpfiles" and replaces the hardcoded list of
exemptions.
Closes: https://bugs.gentoo.org/808781
Signed-off-by: Sam James <sam@gentoo.org>
|
|
|
|
|
|
| |
See: https://archives.gentoo.org/gentoo-dev/message/7bdfdc9a7560fd07436defd0253af0b8
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
Signed-off-by: Sam James <sam@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
| |
Both sys-apps/systemd and sys-libs/pam need to install some files
to these directories without inheriting the eclass.
For future work, we should have a standardised way on opting
out of installed files QA checks, but other QA checks are
already suffering from this issue.
See: https://archives.gentoo.org/gentoo-dev/message/0a96793036a4fdd9ac311a46950d7e7b
Signed-off-by: Sam James <sam@gentoo.org>
|
|
|
|
|
|
|
| |
It's okay to use "keepdir" on /etc/tmpfiles.d.
See: https://archives.gentoo.org/gentoo-dev/message/50558b55dc34f37b238807fc4759640d
Signed-off-by: Sam James <sam@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This adds two tmpfiles related QA checks:
1) Verify packages don't install tmpfiles to /etc/tmpfiles.d, which
is a forbidden (user-configuration) location;
2) Check whether packages inherit tmpfiles.eclass if they're
installing files to /usr/lib/tmpfiles.d.
(This helps to catch packages not calling tmpfiles_process
in pkg_postinst).
Signed-off-by: Sam James <sam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
|
|
|
|
| |
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
|
|
|
|
| |
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
| |
Signed-off-by: Sam James <sam@gentoo.org>
|
|
|
|
|
|
| |
By 2021-07-11 council decision.
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
|
|
|
|
| |
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
DISTUTILS_OPTIONAL skips setting the dependency on setuptools entirely,
so skip checking for its correctness, and verbosely complain if it's
set.
Closs: https://bugs.gentoo.org/800147
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
| |
check if ebuild has a dep on sys-libs/libxcrypt and return
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
|
|
|
|
|
|
|
| |
and re-wrap some lines to fit into 80 char limit
Bug: https://bugs.gentoo.org/728046
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
|
|
|
|
|
| |
Bug: https://bugs.gentoo.org/728046
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
|
|
|
|
| |
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
|
|
|
|
| |
Signed-off-by: Sam James <sam@gentoo.org>
|
|
|
|
|
| |
Thanks-to: [Arfrever]
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
|
|
|
|
|
| |
Bug: https://bugs.gentoo.org/699422
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
|
|
|
|
| |
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
|
|
|
|
| |
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
| |
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
| |
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
|
| |
Make DISTUTILS_USE_SETUPTOOLS check aware of gui_scripts in addition
to console_scripts. Thanks to Arfrever for reporting.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Accept both 'rdepend' and 'bdepend' as DISTUTILS_USE_SETUPTOOLS values
for packages installing entry points. Starting with Python 3.8, these
packages do not require any runtime dependency. However, we do not want
to proactively bother people with updating everything and instead
provide the option to start performing opt-in updates.
Note that technically PyPy3 (that implements Python 3.7 at the moment)
continues requiring additional dependencies for entry point support.
However, we do not support PyPy3 target in stable and generally do not
consider it important enough to maintain extra complexity for.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
|
|
| |
If the package does not install any .egg-info files, i.e. distutils
is probably not used at all, we do not the eclass to create a setuptools
dependency.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
|
|
| |
Make DISTUTILS_USE_SETUPTOOLS check explicitly distinguish rdepend due
to entry points from explicit rdepend. This currently does not change
the result but it will change in the future.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
| |
Fixes: bdcfb21ca5a84567e9c9d6a456374a05e798f78e
Closes: https://bugs.gentoo.org/781878
Signed-off-by: Sam James <sam@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
| |
Thanks to everyone for their help in eradicating
these older ebuilds!
(Including putting up with naggy bugs.)
Bug: https://bugs.gentoo.org/756748
Closes: https://bugs.gentoo.org/656140
Signed-off-by: Sam James <sam@gentoo.org>
|
|
|
|
| |
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
| |
Thanks to Arfrever for help with the pipeline.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
| |
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
| |
Fix DISTUTILS_USE_SETUPTOOLS check to process all Python implementations
with egg-infos present in site-packages (possibly none). This fixes
eclass errors when trying to call distutils-r1 functions when it is
actually disabled in DISTUTILS_OPTIONAL ebuilds. It also reduces noise
while processing.
Closes: https://bugs.gentoo.org/744079
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
| |
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
Allow DISTUTILS_USE_SETUPTOOLS guess to partially evaluate to bdepend
and partially to rdepend. That is the case in dev-python/hypothesis
that installs CLI tools for CPython but not PyPy3. In this case,
rdepend is the expected value.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
| |
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
| |
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Move DISTUTILS_USE_SETUPTOOLS check from distutils-r1.eclass to install
QA checks, and rewrite it to use installed egg-info rather than greps
on input files. This produces less false positives, particularly
in packages that use boilerplate empty 'entry_points' in their setup
script or configuration file.
We also no longer require explicit setuptools RDEPEND for packages using
other entry point types than console_scripts -- instead, we assume that
the package consuming these entry points will bring setuptools
as necessary.
The rough idea is to look at egg-info metadata installed by distutils
or setuptools. Plain distutils installs it as a regular file, while
setuptools as a directory, and that's how we distinguish the two.
For setuptools, we additionally grep entry_points.txt for
`[console_scripts]`, and require RDEPEND when they are present.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
| |
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
| |
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
Introduce a new configuration file for assigning QA check significance
levels to PGnnnn policies. Long-term goal is that this will permit
unified configuration of various QA tools, including pkgcheck, repoman
and install-qa-check.d.
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
|
|
|
|
|
|
| |
this will warn if package installs xml files to /usr/share/appdata
this location is deprecated, files should be installed to
/usr/share/metainfo
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html
Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>
|
|
|
|
|
|
|
| |
These exceptions were made for the sys-apps/nix and sys-apps/guix
packages that are no longer in the tree.
Signed-off-by: Michael Orlitzky <mjo@gentoo.org>
|
|
|
|
|
| |
Closes: https://bugs.gentoo.org/704286
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|
|
|
|
| |
Signed-off-by: Ulrich Müller <ulm@gentoo.org>
|
|
|
|
|
|
|
| |
Closes: https://bugs.gentoo.org/657150
Closes: https://bugs.gentoo.org/696252
Signed-off-by: Aaron Bauman <bman@gentoo.org>
|
|
|
|
|
|
|
|
|
|
|
| |
sys-apps/nix and sys-apps/guix are twins:
- sys-apps/nix manages /nix/store
- sys-apps/guix manages /gnu/store
Added 'gnu' and mentioned packages that own the directory.
Bug: https://bugs.gentoo.org/670902
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
|
|
|
|
|
|
| |
Closes: https://bugs.gentoo.org/670902
Suggested-by: Michał Górny <mgorny@gentoo.org>
Signed-off-by: Zac Medico <zmedico@gentoo.org>
|
|
|
|
|
|
|
|
|
| |
Bugs like bug #670902 get stuck due to unclear maintainership status.
Let's assign it to dev-portage@ as it historicallily lived in portage
source tree and QA does not take it over in bug #670902.
Bug: https://bugs.gentoo.org/670902
Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
|
|
|
|
|
| |
Bug: https://bugs.gentoo.org/696832
Signed-off-by: Michał Górny <mgorny@gentoo.org>
|