blob: 1ffc1d326beb936f6d7e2acf311fdd79f6073233 (
plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
|
#!/bin/bash
# Tests for update-06-copyright hook
# Copyright 2018 Michał Górny
# Distributed under the terms of the GNU General Public License v2 or later
. "${BASH_SOURCE%/*}"/lib.sh
HOOK_PATH=${BASH_SOURCE%/*}/../update-06-copyright
[[ ${HOOK_PATH} == /* ]] || HOOK_PATH=${PWD}/${HOOK_PATH}
# Override ldapsearch for the purpose of the tests
ldapsearch() {
case ${GL_USER} in
fakedev@gentoo.org)
cat <<-EOF
dn: uid=fakedev,ou=devs,dc=gentoo,dc=org
cn: I. M. Developer
gecos: I. M. Developer
EOF
;;
polisher@gentoo.org)
cat <<-EOF
dn: uid=polisher,ou=devs,dc=gentoo,dc=org
cn:: xITEh8SZxYLFhMOzxZvFusW8IFBvbGlzaGVyCg==
gecos: Acelnoszz Polisher
EOF
;;
otherdev@gentoo.org)
cat <<-EOF
dn: uid=otherdev,ou=devs,dc=gentoo,dc=org
cn: John O. Developer
gecos: John O. Developer
EOF
;;
esac
}
# Error message patterns
FAIL_NO_SIGNOFF="*: no GCO sign-off present"
FAIL_EMAIL="*: no sign-off matching committer's e-mail address found!
*"
FAIL_SYNTAX="*: malformed sign-off (should be: real name <email>)!
*"
FAIL_REALNAME="*: name of sign-off does not match realname in LDAP!
*"
FAIL_LICENSE="*: DCO-1.1 sign-off used on license directory!"
# Non-developer commit tests (for repos that allow those)
export GL_USER=nondev@example.com
export GIT_COMMITTER_NAME='Non A. Dev'
export GIT_COMMITTER_EMAIL=${GL_USER}
export GIT_AUTHOR_NAME=${GIT_COMMITTER_NAME}
export GIT_AUTHOR_EMAIL=${GIT_COMMITTER_EMAIL}
einfo "Simple non-developer commit tests"
eindent
tbegin "Valid GCO sign-off"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "Multiple sign-offs (including valid)"
git commit --allow-empty -m "A commit
Signed-off-by: Somebody Else <else@example.com>
Some-other-tag: blah blah
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>
Signed-off-by: Also Him <him@example.com>" -q
test_success
tbegin "No sign-off"
git commit --allow-empty -m "A commit" -q
test_failure "${FAIL_NO_SIGNOFF}"
tbegin "Mismatched e-mail address in sign-off"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME} <foo@example.com>" -q
test_failure "${FAIL_EMAIL}"
tbegin "Different name in sign-off"
git commit --allow-empty -m "A commit
Signed-off-by: Foo Bar <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "Case-insensitive e-mail matching"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME^^} <${GIT_COMMITTER_EMAIL^^}>" -q
test_success
tbegin "Linux DCO sign-off"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}> (DCO-1.1)" -q
test_success
eoutdent
einfo "License directory tests"
eindent
tbegin "GCO sign-off on licenses directory"
mkdir -p licenses || die
echo 'Unmodifiable license' > licenses/mylicense || die
git add licenses/mylicense
git commit -m "A commit with license
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "Linux DCO sign-off on licenses directory"
mkdir -p licenses || die
echo 'Unmodifiable license' > licenses/mylicense || die
git add licenses/mylicense
git commit -m "A commit with license
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}> (DCO-1.1)" -q
test_failure "${FAIL_LICENSE}"
eoutdent
einfo "Syntax check tests"
eindent
tbegin "Invalid sign-off (no e-mail address)"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME}" -q
test_failure "${FAIL_SYNTAX}"
tbegin "Invalid sign-off (no name)"
git commit --allow-empty -m "A commit
Signed-off-by: <${GIT_COMMITTER_EMAIL}>" -q
test_failure "${FAIL_SYNTAX}"
tbegin "Invalid + valid sign-off (should be rejected)"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>
Signed-off-by: Yo Momma" -q
test_failure "${FAIL_SYNTAX}"
eoutdent
# Now with a different author
export GIT_AUTHOR_NAME='Somebody Else'
export GIT_AUTHOR_EMAIL='selse@example.com'
einfo "Committer != author, non-developer tests"
eindent
tbegin "Committer != author (non-dev) with valid GCO sign-off"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "Committer != author (non-dev) with only author sign-off"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_AUTHOR_NAME} <${GIT_AUTHOR_EMAIL}>" -q
test_failure "${FAIL_EMAIL}"
eoutdent
# Developer commit tests
export GL_USER=fakedev@gentoo.org
export GIT_COMMITTER_NAME='I. M. Developer'
export GIT_COMMITTER_EMAIL=${GL_USER}
export GIT_AUTHOR_NAME=${GIT_COMMITTER_NAME}
export GIT_AUTHOR_EMAIL=${GIT_COMMITTER_EMAIL}
einfo "Simple developer commit tests"
eindent
tbegin "Valid GCO sign-off"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "E-mail mismatch"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME} <fakedev@example.com>" -q
test_failure "${FAIL_EMAIL}"
tbegin "Real name mismatch"
git commit --allow-empty -m "A commit
Signed-off-by: fakedev <${GIT_COMMITTER_EMAIL}>" -q
test_failure "${FAIL_REALNAME}"
tbegin "Case insensitivity"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME^^} <${GIT_COMMITTER_EMAIL^^}>" -q
test_success
eoutdent
export GIT_AUTHOR_NAME='Somebody Else'
export GIT_AUTHOR_EMAIL='selse@example.com'
einfo "Proxied commit tests"
eindent
tbegin "Developer + author GCO sign-off"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_AUTHOR_NAME} <${GIT_AUTHOR_EMAIL}>
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "Only developer GCO sign-off"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "Only author GCO sign-off"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_AUTHOR_NAME} <${GIT_AUTHOR_EMAIL}>" -q
test_failure "${FAIL_EMAIL}"
eoutdent
einfo "Hardcore unicode tests"
eindent
export GL_USER=polisher@gentoo.org
export GIT_COMMITTER_NAME='Ąćęłńóśźż Polisher'
export GIT_COMMITTER_EMAIL=${GL_USER}
export GIT_AUTHOR_NAME=${GIT_COMMITTER_NAME}
export GIT_AUTHOR_EMAIL=${GIT_COMMITTER_EMAIL}
tbegin "All uppercase"
git commit --allow-empty -m "A commit
Signed-off-by: ĄĆĘŁŃÓŚŹŻ POLISHER <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "All lowercase"
git commit --allow-empty -m "A commit
Signed-off-by: ąćęłńóśźż polisher <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "Mixed case"
git commit --allow-empty -m "A commit
Signed-off-by: ąĆĘŁń󜏯 Polisher <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "ASCII (GECOS) version"
git commit --allow-empty -m "A commit
Signed-off-by: Acelnoszz Polisher <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "Uppercase GECOS"
git commit --allow-empty -m "A commit
Signed-off-by: ACELNOSZZ POLISHER <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "Lowercase GECOS"
git commit --allow-empty -m "A commit
Signed-off-by: acelnoszz polisher <${GIT_COMMITTER_EMAIL}>" -q
test_success
eoutdent
export GL_USER=otherdev@gentoo.org
export GIT_COMMITTER_NAME='I. M. Developer'
export GIT_COMMITTER_EMAIL=fakedev@gentoo.org
export GIT_AUTHOR_NAME=${GIT_COMMITTER_NAME}
export GIT_AUTHOR_EMAIL=${GIT_COMMITTER_EMAIL}
einfo "Committer != pusher tests"
eindent
tbegin "Valid GCO sign-off"
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>" -q
test_success
tbegin "Pusher GCO sign-off only"
git commit --allow-empty -m "A commit
Signed-off-by: John O. Developer <${GL_USER}>" -q
test_failure "${FAIL_EMAIL}"
tbegin "Committer realname mismatch (XFAIL)"
git commit --allow-empty -m "A commit
Signed-off-by: Wrong Name Here <${GIT_COMMITTER_EMAIL}>" -q
test_success
eoutdent
einfo "Merge commit tests"
eindent
tbegin "Merge commit with B-branch commit missing sign-off"
git checkout -q -b test-branch
git commit --allow-empty -m "A commit" -q
git checkout -q master
export GIT_COMMITTER_NAME='John O. Developer'
export GIT_COMMITTER_EMAIL=${GL_USER}
git commit --allow-empty -m "Another master commit
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>" -q
git merge -q -m "Test merge commit
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>" -q test-branch
test_failure "${FAIL_NO_SIGNOFF}"
tbegin "Merge commit missing sign-off"
git checkout -q -b test-branch
git commit --allow-empty -m "A commit
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>" -q
git checkout -q master
git commit --allow-empty -m "Another master commit
Signed-off-by: ${GIT_COMMITTER_NAME} <${GIT_COMMITTER_EMAIL}>" -q
git merge -q -m "Test merge commit" -q test-branch
test_failure "${FAIL_NO_SIGNOFF}"
eoutdent
|
GitWeb