diff options
| author |   Florian Weimer <fweimer@redhat.com> | 2022-08-03 11:41:53 +0200 |
|---|---|---|
| committer | Florian Weimer <fweimer@redhat.com> | 2022-08-03 11:43:04 +0200 |
| commit | 9001cb1102cddba54f0e84e147dfbb0356067356 (patch) | |
| tree | 752100897824af704ceb553e42867960e41a87f7 /elf | |
| parent | nptl: Remove uses of assert_perror (diff) | |
| download | glibc-9001cb1102cddba54f0e84e147dfbb0356067356.tar.gz glibc-9001cb1102cddba54f0e84e147dfbb0356067356.tar.bz2 glibc-9001cb1102cddba54f0e84e147dfbb0356067356.zip | |
assert: Do not use stderr in libc-internal assert
Redirect internal assertion failures to __libc_assert_fail, based on
based on __libc_message, which writes directly to STDERR_FILENO
and calls abort. Also disable message translation and reword the
error message slightly (adjusting stdlib/tst-bz20544 accordingly).
As a result of these changes, malloc no longer needs its own
redefinition of __assert_fail.
__libc_assert_fail needs to be stubbed out during rtld dependency
analysis because the rtld rebuilds turn __libc_assert_fail into
__assert_fail, which is unconditionally provided by elf/dl-minimal.c.
This change is not possible for the public assert macro and its
__assert_fail function because POSIX requires that the diagnostic
is written to stderr.
Reviewed-by: Adhemerval Zanella <adhemerval.zanella@linaro.org>
Diffstat (limited to 'elf')
| -rw-r--r-- | elf/Makefile | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/elf/Makefile b/elf/Makefile index fd77d0c7c8..3386f0ce77 100644 --- a/elf/Makefile +++ b/elf/Makefile @@ -1283,6 +1283,7 @@ $(objpfx)dl-allobjs.os: $(all-rtld-routines:%=$(objpfx)%.os) rtld-stubbed-symbols = \ __GI___pthread_disable_asynccancel \ __GI___pthread_enable_asynccancel \ + __libc_assert_fail \ __pthread_disable_asynccancel \ __pthread_enable_asynccancel \ calloc \ |